Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): presto-on-hive - Adding db name to the presto on hive urn #6024

Merged
merged 6 commits into from
Oct 19, 2022
Merged

fix(ingest): presto-on-hive - Adding db name to the presto on hive urn #6024

merged 6 commits into from
Oct 19, 2022
+4,864 −2,305

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 22, 2022
@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 0m 11s ⏱️
   743 tests    740 ✔️ 3 💤 0 ❌
1 488 runs  1 482 ✔️ 6 💤 0 ❌

Results for commit cc6932b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests   593 ✔️  11m 49s ⏱️
147 suites      4 💤
147 files        0 ❌

Results for commit cc6932b.

♻️ This comment has been updated with latest results.

@treff7es treff7es marked this pull request as draft September 22, 2022 15:59
@aezomz
Copy link
Contributor

aezomz commented Sep 24, 2022

possible to make this configurable? if not existing user will be impacted. thanks!

@treff7es treff7es closed this Sep 27, 2022
@treff7es treff7es reopened this Oct 18, 2022
@treff7es treff7es marked this pull request as ready for review October 18, 2022 20:55
shirshanka
shirshanka approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 0545f3c into datahub-project:master Oct 19, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @shirshanka @cccs-tom
fix(ingest): presto-on-hive - Adding catalog name to the presto on hi…
8e68d7b 
…ve urn (datahub-project#6024)

Co-authored-by: Shirshanka Das <[email protected]>
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@treff7es @shirshanka @cccs-tom
fix(ingest): presto-on-hive - Adding catalog name to the presto on hi…
088e66a 
…ve urn (datahub-project#6024)

Co-authored-by: Shirshanka Das <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treff7es @aezomz @shirshanka